On Fri, Nov 25, 2022 at 4:50 PM Liam Howlett <liam.howlett@xxxxxxxxxx> wrote:
>
> Rename the fallthrough attribute to better align with the kernel
> version. Copy the definition from include/linux/compiler_attributes.h
> including the #else clause. Adding the #else clause allows the tools
> compiler.h header to drop the check for a definition entirely and keeps
> both definitions together.
Thanks for doing this! Consistency with `tools/` is nice to have indeed.
I see that `compiler-gcc.h` is included for Clang too in `tools/`, so
it looks fine to me:
Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
In the future, it could be nice to enable the warning for Clang too,
though I see it requires a few cleanups.
Another idea is to use something similar to `compiler_attributes.h` in
`tools/` (perhaps just copying it and removing what is not needed?).
Cheers,
Miguel
