If a reserved name is used as the destination of a goto, its associated label won't be valid and at linearization time no BB will can be created for it, resulting in an invalid IR. So, catch such gotos at evaluation time and mark the function to not be linearized. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> --- evaluate.c | 2 ++ validation/linear/invalid-labels0.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/evaluate.c b/evaluate.c index 14953f195fcc..99a9ee72d11f 100644 --- a/evaluate.c +++ b/evaluate.c @@ -3751,6 +3751,8 @@ static void evaluate_goto_statement(struct statement *stmt) sparse_error(stmt->pos, "label '%s' was not declared", show_ident(label->ident)); current_fn->bogus_linear = 1; } + if (label->namespace == NS_NONE) + current_fn->bogus_linear = 1; } struct symbol *evaluate_statement(struct statement *stmt) diff --git a/validation/linear/invalid-labels0.c b/validation/linear/invalid-labels0.c index ae3bf7283fb8..a15e9d434011 100644 --- a/validation/linear/invalid-labels0.c +++ b/validation/linear/invalid-labels0.c @@ -11,7 +11,6 @@ void bar(void) /* * check-name: invalid-labels0 * check-command: test-linearize -Wno-decl $file - * check-known-to-fail * * check-output-ignore * check-output-excludes: END -- 2.26.0
