It's not allowed to do a goto into an expression statement.
For exemple, it's not well defined what should happen if such
an expression is not otherwise reachable and/or can be optimized
away. For such situations GCC issues an error, clang doesn't
and produce a valid IR but Spare produce an invalid IR with
branches to unexisting BBs.
The goal of the patches in this series is:
*) to detect such gotos at evaluation time;
*) issue a sensible error message;
*) avoid the linearization of functions with
invalid gotos.
This series is an alternative to the one named
"detect invalid branches in the IR" whch was posted
last week.
-- Luc
Luc Van Oostenryck (17):
bad-goto: add testcase for 'jump inside discarded expression statement'
bad-goto: add testcases for linearization of invalid labels
bad-goto: add more testcases
bad-goto: do not linearize if the IR will be invalid
bad-goto: reorg test in evaluate_goto_statement()
bad-goto: simplify testing of undeclared labels
bad-goto: do not linearize function with undeclared labels
bad-goto: catch labels with reserved names
scope: no memset() needed after __alloc_scope()
scope: move scope opening/ending inside compound_statement()
scope: make function scope the same as the body block scope
scope: s/{start,end}_symbol_scope/{start,end}_block_scope/
scope: let labels have their own scope
scope: add is_in_scope()
scope: give a scope for labels & gotos
bad-goto: catch gotos inside expression statements
bad-goto: cleanup evaluate_goto()
evaluate.c | 25 +++++++++++++--
expression.c | 4 +--
linearize.c | 2 +-
parse.c | 23 +++++++-------
parse.h | 1 +
scope.c | 33 +++++++++++++++----
scope.h | 10 ++++--
symbol.h | 4 +++
validation/label-scope1.c | 42 +++++++++++++++++++++++++
validation/label-stmt-expr1.c | 29 +++++++++++++++++
validation/linear/goto-and-expr-stmt0.c | 33 +++++++++++++++++++
validation/linear/invalid-labels0.c | 18 +++++++++++
12 files changed, 199 insertions(+), 25 deletions(-)
create mode 100644 validation/label-scope1.c
create mode 100644 validation/label-stmt-expr1.c
create mode 100644 validation/linear/goto-and-expr-stmt0.c
create mode 100644 validation/linear/invalid-labels0.c
base-commit: 0f5a39dcea89c66236c04815b77b107763873431
--
2.26.0
