On Wed, Nov 06, 2019 at 05:58:06PM +0000, Ben Dooks wrote: > > Ok, I've split this out now, I agree it is probably better suited to > being seperate as it may well grow as we add formats and anything > else that might be required. > > I'll try and finish looking at the tests tomorrow, ande about the > use of check_assignment_types(), whether we could extend it with > some sort of flags field, such as (IGNORE_ADDRESS_SPACE). > > I've started putting up: > https://github.com/bjdooks-ct/sparse bjdooks/printf22 Yes, that's fine. There is just that, as I said, you surely want to move the code around a little at the start of verify_format_attribute() so that the warning "not a format string?" can be showed again (the check I made to the expr just do a silent early return if the string is not a literal string). Best regards, -- Luc
