On Mon, Nov 04, 2019 at 10:46:44PM +0100, Luc Van Oostenryck wrote: > On Fri, Nov 01, 2019 at 04:36:51PM +0000, Ben Dooks wrote: > > I've put the latest code up at: > > > > https://github.com/bjdooks-ct/sparse bjdooks/printf20 > > > > I think it has all the issues dealt with. > > > > I can't currently post or do a final test as away from work laptop. > > Thank you. I think that the only missign thing are: 1) eliminate the call to strcmp() on the typediff 2) do a custom type checking instead of calling check_assignment_types() What is your plan about them? There is also one more thing I would like: it's that you move all the code in evaluate.c in a separated file (for example verify-format.c) and have just verify_format_attribute() exported. For the moment, it's not really possible because of the dependence on check_assignment_types() but it can nicely be do,e once 1) & 2) are done. -- Luc
