On Mon, Feb 18, 2019 at 09:05:30PM +0000, Ramsay Jones wrote: > > > On 18/02/2019 20:20, Luc Van Oostenryck wrote: > [snip] > >> I have some minor comments on the patches, but I will have to > >> wait until tomorrow now (I have to get some sleep). > > And I still have not had time (something came up), sorry. :( No worries. There is no urgency for these patches. > >> However, there was one thing I wanted to mention tonight. These > >> patches change the interface of cgcc in a non-backward compatible > >> way. In particular, the -target=<spec> parameter, which can and > >> pretty much _had_ to be specified multiple times (well OK twice > >> in practice), to specify _both_ the 'OS' and 'arch' specs. > > > > Indeed. It was a quick try to cleanup this code and I didn't > > realized that it broke '-target' (I also had no idea you're > > using it. I guess I'm understanding better now your email from > > last week mentioning it). > > Hmm, I doubt it. To be clear, I don't use '-target', I just > read the patches and noticed the non-backward compatible > behaviour. ;-) Ah, OK ... > >> Note that the tokens 'host_os_specs' and 'host_arch_specs' > >> were useful (even though they _could have_ been replaced > >> on the command-line by "$(uname -s)" and "$(uname -m)" > >> respectively). ... I understood this as meaning: "were (effectively) useful (to me)". Best regards, -- Luc
