Re: [PATCH] build: check if sparse-llvm needs libc++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 18, 2018 at 01:06:24PM -0800, Josh Triplett wrote:
> On Tue, Dec 18, 2018 at 09:23:52PM +0100, Luc Van Oostenryck wrote:
> > The output of 'llvm-config --system-libs' is not really complete
> > as libc++ may be needed but not reported as such by this command.
> > 
> > So, use the output of 'llvm-config --cxxflags' to check this.
> > 
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> > ---
> >  Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index beaff7a98..daac0297c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -163,6 +163,7 @@ LLVM_LDFLAGS := $(shell $(LLVM_CONFIG) --ldflags)
> >  LLVM_CFLAGS := -I$(shell $(LLVM_CONFIG) --includedir)
> >  LLVM_LIBS := $(shell $(LLVM_CONFIG) --libs)
> >  LLVM_LIBS += $(shell $(LLVM_CONFIG) --system-libs 2>/dev/null)
> > +LLVM_LIBS += $(shell $(LLVM_CONFIG) --cxxflags | grep -q -e '-stdlib=libc++' && echo -lc++)
> 
> Please pass -F to grep here.

Yes, of course.
Thanks for noticing this.

-- Luc



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux