Re: [PATCH 1/4] as-name: add and use show_as()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 09, 2018 at 02:48:15AM +0000, Ramsay Jones wrote:
> On 08/12/2018 22:03, Luc Van Oostenryck wrote:
> > @@ -3018,13 +3018,13 @@ static struct symbol *evaluate_cast(struct expression *expr)
> >  	}
> >  
> >  	if (!tas && sas > 0)
> > -		warning(expr->pos, "cast removes address space of expression (<asn:%d>)", sas);
> > +		warning(expr->pos, "cast removes address space '%s' from expression", show_as(sas));
> >  	if (tas > 0 && sas > 0 && tas != sas)
> > -		warning(expr->pos, "cast between address spaces (<asn:%d>-><asn:%d>)", sas, tas);
> > +		warning(expr->pos, "cast between address spaces (%s - %s)", show_as(sas), show_as(tas));
> 
> s/-/->/ ?

Yes, it's slightly more clear.

Thanks,
-- Luc 



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux