On Thu, Nov 22, 2018 at 02:56:40PM +0000, Ramsay Jones wrote: > > > On 22/11/2018 13:44, Luc Van Oostenryck wrote: > > From: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> > > > > Currently, when used on the kernel, sparse issues a bunch > > of warnings like: > > warning: constant 0x100000000 is so big it is long > > > > These warning are issued because when there is a discrepancy > > between the type as indicated by the suffix (or the absence > > of a suffix) and the real type as selected by the type > > suffix *and* the value of the constant. > > > > Since there is nothing incorrect with this discrepancy, > > (no bits are lost) these warnings are more annoying than useful. > > So, make them depending on a new warning flag -Wconstant-suffix > > and make it off by default. > > > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> > > Looks *very* good to me! :-D OK, pushed to upstream. Best regards, -- Luc
