On Mon, Oct 22, 2018 at 2:42 AM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Sun, Oct 21, 2018 at 07:14:13PM +0200, Miguel Ojeda wrote:
> > +#if __has_attribute(__fallthrough__)
> > +# define __fallthrough __attribute__((__fallthrough__))
> > +#else
> > +# define __fallthrough
> > +#endif
>
> Why is the #else not:
>
> # define __fallthrough /* fallthrough */
>
> Would this solve the Coverity problem, or does Coverity look at the raw
> source code before preprocessing?
That wouldn't work if Coverity follows the standard, because it is
required that comments are removed right before the preprocessing
phase.
That is one of the advantages vs. the attribute that I mentioned:
"""
We can actually use a #define for it like for the rest of
attributes/extensions, which is not possible with a comment, (...)
"""
Cheers,
Miguel
