On Thu, Feb 15, 2018 at 11:53 AM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: >> So I do think the warning itself should be off by default - but maybe >> the "known but ignored" table should exist so that sparse people can >> say "is there a new attribute that I need to look at"? > > Yes, I think that the off by default is a clear thing. > For the table, yes, I sort of agree with you and Josh at some level > but in practice I don't think it will be of any help. There is > already a number of attributes (and builtins) sparse *should* act on > (for attributes, I'm thinking to 'noreturn', for example) but haven't > and this for a long time already. I also think that once the warning > will be off by default, the table won't be updated anymore. I agree with the default should be turn off for kernel checking to reduce the noise. The known attribute table does have some usage. If the developer are writing sparse related checking, he might want to know if he misspell some sparse specific attribute. The other case is that, some sparse specific attribute is not implement in this version of sparse. It might be useful to know. In this case, the developer can turn this warning on to catch if there is misspell of the "adress_space" attribute for example. I suggest change default on off, but keep the warning option if some one want to turn it on. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
