On Thu, Feb 15, 2018 at 09:33:14AM -0800, Linus Torvalds wrote: > On Thu, Feb 15, 2018 at 7:57 AM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote: > > > > I absolutely agree that these have been annoying. However, they've also > > been useful in the past to identify new flags used in the kernel and > > other projects that we may need to actually act on, rather than just > > ignore. > > I think the issue is that the warning is useful for _sparse_ > developers, but not to actual users. > > So I do think the warning itself should be off by default - but maybe > the "known but ignored" table should exist so that sparse people can > say "is there a new attribute that I need to look at"? Yes, I think that the off by default is a clear thing. For the table, yes, I sort of agree with you and Josh at some level but in practice I don't think it will be of any help. There is already a number of attributes (and builtins) sparse *should* act on (for attributes, I'm thinking to 'noreturn', for example) but haven't and this for a long time already. I also think that once the warning will be off by default, the table won't be updated anymore. So, I'm not sure. I can't say I disagree but I can't say I'm convinced it will be of any help. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
