On Sat, Jan 20, 2018 at 8:27 PM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
> On Sat, Jan 20, 2018 at 07:36:24PM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> with help from Linus. (many moons ago)
>>
>> sparse addition to print all compound/composite global data symbols
>> with their sizes and alignment.
>>
>> usage: -list-symbols
>> Example: (in kernel tree)
>> make C=2 CF="-list-symbols" arch/x86_64/kernel/smpboot.o
>> arch/x86/kernel/smpboot.c:99:1: struct cpuinfo_x86 [addressable] [noderef] [toplevel] <asn:3>cpu_info: compound size 240, alignment 8
>
> If this only lists compound symbols, it seems a bit strange to me
> to use '-list-symbols' as the option name. Maybe you could go one
> step further an have '-list-symbols=compound' and if needed it can
> be extended to '-list-symbols=all'.
I think maybe it can be group with the "-v<debug>" options. e.g. "-vcompound".
After all it is showing some debug information very similar to "-ventry".
>
> Not really needed as it's already included indirectly but it
> won't hurt, of course.
>...
>
> Not needed since already declared in lib.h.
Agree here and other Luc's feedback, so I skip the duplication.
>
>> +static void list_all_symbols(struct symbol_list *list)
>> +{
>> + struct symbol *sym;
>> +
>> + FOR_EACH_PTR(list, sym) {
>> + /* Only show arrays, structures, unions, enums, & typedefs */
This comment is a bit confusing for me. It mention "Only show ... *enums*"
>
>> + if (sym->type == SYM_FN || sym->type == SYM_ENUM)
>> + continue;
>> + if (!sym->ctype.base_type)
>> + continue;
>> + if (sym->ctype.base_type->type == SYM_FN)
>> + continue;
>> + if (sym->ctype.base_type->type == SYM_ENUM)
>> + continue;
Here it skips enums. Not consistent with previous comment
about showing enums. Am I missing something obvious?
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
