On Sat, Jan 20, 2018 at 07:36:24PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> with help from Linus. (many moons ago)
>
> sparse addition to print all compound/composite global data symbols
> with their sizes and alignment.
>
> usage: -list-symbols
> Example: (in kernel tree)
> make C=2 CF="-list-symbols" arch/x86_64/kernel/smpboot.o
> arch/x86/kernel/smpboot.c:99:1: struct cpuinfo_x86 [addressable] [noderef] [toplevel] <asn:3>cpu_info: compound size 240, alignment 8
If this only lists compound symbols, it seems a bit strange to me
to use '-list-symbols' as the option name. Maybe you could go one
step further an have '-list-symbols=compound' and if needed it can
be extended to '-list-symbols=all'.
> --- orig/sparse.c
> +++ next/sparse.c
> @@ -36,6 +36,7 @@
> #include "allocate.h"
> #include "token.h"
> #include "parse.h"
> +#include "ptrlist.h"
Not really needed as it's already included indirectly but it
won't hurt, of course.
> +extern int list_symbols;
Not needed since already declared in lib.h.
> +static void list_all_symbols(struct symbol_list *list)
> +{
> + struct symbol *sym;
> +
> + FOR_EACH_PTR(list, sym) {
> + /* Only show arrays, structures, unions, enums, & typedefs */
> + if (!(sym->namespace & (NS_STRUCT | NS_TYPEDEF | NS_SYMBOL)))
> + continue;
> + /* Only show types we actually examined (ie used) */
> + if (!sym->bit_size)
> + continue;
Even after being examined, 'bit_size' can stay zero if there is
some errors. You can directly use 'if (!sym->examined)' if you
want but I think it's better to adjust the comment.
> + if (sym->type == SYM_FN || sym->type == SYM_ENUM)
> + continue;
> + if (!sym->ctype.base_type)
> + continue;
> + if (sym->ctype.base_type->type == SYM_FN)
> + continue;
> + if (sym->ctype.base_type->type == SYM_ENUM)
> + continue;
> + if (sym->ctype.base_type->type == SYM_BASETYPE)
> + continue;
It's a bit dangereous here. You should check for SYM_NODE.
I also think it would be better and simpler to use the helpers
is_func_type(), is_int_type(), ... or add is_compound_type().
> + /* Don't show unnamed types */
> + if (!sym->ident)
> + continue;
> + info(sym->pos, "%s: compound size %u, alignment %lu",
> + show_typename(sym),
> + sym->bit_size >> 3,
bits_to_bytes() should be used here.
Regards,
Luc Van Oostenryck
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
