On Mon, Oct 30, 2017 at 05:53:49AM +0800, Christopher Li wrote: > On Mon, Oct 30, 2017 at 1:28 AM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > The goal of the initial patch, as stated by Jeff, was: > > "The fedora packaging tools want to *override* $CFLAGS when building sparse" > > > > This version doesn't allow to override CFLAGS. > > See what happens with 'make CFLAGS=-O3' for example. > > The original patch proposed by Jeff does not allow usage of > "make CFLAGS=-O3" either. I take a look at your patch, it behave > the same way in this regard. Do you mean I should change the > commit title to *append* CFLAGS instead of override? Since for flags like -O[0123] but also for all flags like -f[no-]xxx and all sort of others settings in GCC and in a multitude of others programs it's the last value that matters, appending to CFLAGS *is* the usual way to *override* previous settings. Jeff's patch allowed that, mine too but yours not. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
