On Mon, Sep 18, 2017 at 5:51 PM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
> Chris,
>
> Please, pull these patches for master.
Ah, I can't find the exact corresponding patch series in the email.
So I will just comment from the git change.
=========quote===========
commit ae7fd3b06c225fd8faf67c3e20db07b64eca7fc3
don't output value of anonymous symbol's pointer
The value of this pointer is of no use unless you're
using a debugger (or just to see if two things are
identical or not) and it's presence produces noise
when comparing the output of two runs for testing.
Change this by issuing it only if 'verbose' is set.
diff --git a/linearize.c b/linearize.c
index 42d1680..b69f838 100644
--- a/linearize.c
+++ b/linearize.c
@@ -120,7 +120,7 @@ const char *show_pseudo(pseudo_t pseudo)
break;
}
expr = sym->initializer;
- snprintf(buf, 64, "<anon symbol:%p>", sym);
+ snprintf(buf, 64, "<anon symbol:%p>", verbose ? sym : NULL);
=======================================================
Very trivial feed back:
I think it is better not print out the %p for NULL.
Just skip the %p if not verbose was set.
BTW, I understand you are reluctant to make trivial change to very
old series of branch. That make sense.
In that case, I can make a topic branch to track the feedback and fix up
as incremental change. Then integrate that branch when all the feedback
settle down. I don't mind writing some feedback patches myself if
you prefer.
Thanks
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
