On Thu, Aug 17, 2017 at 8:49 AM, Christopher Li <sparse@xxxxxxxxxxx> wrote:
>>
>> + if (!sym->ident) { // top-level asm
>
> Maybe here we should check the statement is really top-level asm?
> Later on we might have more than top-level asm as with sym->ident == NULL.
Sure but it's currently how they must be detected.
In fact (like the name may suggest) this patch is part of a series
that better deal with top-level asm (they are not really statement!').
For example, top-level asm must be parsed as basic asm and not
extended asm.
So yes, I totally agree, but not now.
-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
