Re: [PATCH] Give the constant pseudo value a size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On 13 August 2017 at 05:18, Christopher Li <sparse@xxxxxxxxxxx> wrote:
> This is actually easier than I though.
> It is also very simple to reason about.
>
> If you are not looking at the size field at all.
> It is exactly the same as before, except we
> create a few more pseudo for the same value
> that have different size.
>
> The size just tag along the constant pseudo.
> Which did not change any way.
>

I assume that you have not yet applied this approach to Sparse-LLVM
and tested that it works for var arg calls? I would suggest completing
the changes so that it can be tested thoroughly.

I personally don't have a preference one way or the other which approach we use.

The push approach has the benefit that it makes clear what arguments
are being passed in a call. Previously this information was not
revealed in the Sparse linearized dump. It would be a shame to lose
that information - perhaps you could still dump the arguments along
with a call?

Second benefit to me is that I have already incorporated this into
dmrC so changing it will mean rework for me.

BTW one could also have a more restricted 'push' solution that is
specific to var arg calls - i.e. only capture the arguments when
calling a var arg function, and avoid putting the push instructions
into the linear stream.

Regards
Dibyendu
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux