On Thu, Aug 10, 2017 at 6:00 PM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: > > It's many months ago so I may not remember the details correctly but ... > > The initial version Nicolai posted (or maybe it was the second) *had* > function to abstract the operations and it was, IMO, really not very readable Ok. I can try to dig them out and see the original form. > and I asked him to change to something simpler like simply using > X |= M or X &= ~M when possible. > It's what he did and it was, IMO, much more readable. > > Meanwhile, I also tried on my side to have some nice & cleaner bit > representation. It looked promising at first but was deceiving at the end. > > So, I think that this series is much more valuable upstreamed than waiting > for some hypothetical super clean abstract layer for those few bits. Completely agree. I want to make them upstream after the release. No question about it. Even as it is is acceptable for after release. > Of course, if you have some concrete set of patches making this better, > I would be glad to take a look at it and change my mind. > Otherwise, please consider it for upstreaming directly after the release > and improving the bit representation and the abstraction layer can always > be done later too. That is what I mean by "suggestion only". It means I will apply it regardless the suggestion has been follow or not. Remind me a git pull for it after the release. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
