On Thu, Aug 10, 2017 at 3:16 AM, Christopher Li <sparse@xxxxxxxxxxx> wrote: >> + // replace (A & M) >> S >> + // by (A >> S) & (M >> S) > > A little bit suggestion base on my previous reading and question ask on > this. When I first read the comment without reading the code, then I would > wondering why (A>>S) & (M>>S) is simpler. The following code actually > explain the constant mask very well. So the comment best understand if > the code was read. Adding some comment on M is constant will help a > lot in the comment. Yes. In fact, these patches still need to have a proper commit message. I've added a not for now. --Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
