On Thu, Aug 10, 2017 at 8:26 AM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: > > Anyway, it's very temporary because the code still put the > phi-nodes at wrong places. > This simplify_one_symbol() is replaced by the new SSA construction > branch. > > Believe it or not but this placement of phi-nodes is a much bigger > issue than those undefined vars. For example, on the kernel, > this patch has exactly zero (visible) effect. But every non-trivial > piece of code is plainly very wrong because of those bad phi-nodes. I can totally see that. My way to explain to myself is that, it is all about the SSA dominance property. Violate the properly == bad things can happen. I can use the property to reason about phi node placements, Also reason this patch as well. > Yes, I'll do later. > (if you want just for testing, please take the ref in the cover letter > and drop the top patches. Unless comments from you, I don't > have the intention to change something to these two patches) I can do more testing too. Thanks! Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
