On Wed, Jul 19, 2017 at 09:26:29AM -0400, Christopher Li wrote: > On Tue, Jul 18, 2017 at 8:07 PM, Christopher Li <sparse@xxxxxxxxxxx> wrote: > > ====================== > > test_menu_iteminfo: > > .L0: > > <entry-point> > > phisrc.32 %phi3(ansi) <- $1 > > br .L1 > > > > .L1: > > phi.32 %r1(ansi) <- %phi3(ansi), %phi4(ansi) > > cbr %r1(ansi), .L4, .L5 > > > > .L4: > > cast.64 %r3 <- (64) stringA > > br .L5 > > > > .L5: > > cbr %r1(ansi), .L6, .L2 > > > > .L6: > > ptrcast.64 %r6 <- (64) %r3 > > ptrcast.64 %r8 <- (64) VOID > > call.64 %r9 <- strcpy, %r6, %r8 > > br .L2 <=============== L2 merge with L7 > > > > .L2: > > seteq.32 %r11 <- %r1(ansi), $0 > > phisrc.32 %phi4(ansi) <- %r11 > > cbr %r1(ansi), .L1, .L3 > > > > .L3: > > ret > > ====================== > > test_menu_iteminfo: > > .L0: > > <entry-point> > > br .L4 <========= phisrc3 get optimize away. This seems wrong > > I see more what is going on there now. > Basically we have %phi3 = 1, a constant. > There for when control flow go from L0->L1, %r1 = %phi3 = 1. > It will go to L4 for sure. > > So L0 modify to goto L4 directly. That is fine. My first analysis was wrong, the real problem is closer from here. As far as I can currently see, the problem is related to the fact that: - the joint was at L1 (who had 2 parents: L0 & L2) - L4 wasn't a joint (the only parent was L1) but after the first call to try_to_simplify_bb() it's not true anymore: - L1 is not a trivial joint, this is fine - L4 become a *real* joint (it can receive %r1 value from L1 or implicitely from L0). This is still fine for L4 but not anymore for its successor L5. One way to see the problem is that the fix 852801f8b is not enough. My first guess would be that the simplification made by try_to_simplify_bb() is valid only if the controlling pseudo is local to the current BB. Still looking at this. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
