On Sat, Jul 29, 2017 at 9:17 AM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: >> My first reaction was surprise that you didn't go for the Makefile >> idea - setting '-Wno-vla' would be the simplest solution. ;-) Yes, I am convince too. I haven't thought of that. You can submit a patch for '-Wno-vla'. I will apply it, but most likely after this release. >> My second thought was, have you done some timing tests (no I haven't) >> and determined that this causes a noticeable slowdown? I did some limited test it is within std on kernel compile. But I am not very happy about the stack usage per macro will expand to 8 argument structs regardless how few arguments used myself. The -Wno-vla is better idea. > Also, this is not IMO -rc4+ material. Agree, because it changes the code behavior. Do you mind have the '-Wno-vla' in -rc5? That should not change any code it generate. I am fine either way. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
