On Wed, Jul 12, 2017 at 10:27:25PM -0700, Christopher Li wrote: > From 7264a822d9d9e545152ac675fbc5b5e970ce254b Mon Sep 17 00:00:00 2001 > From: Christopher Li <sparse@xxxxxxxxxxx> > Date: Wed, 12 Jul 2017 14:46:50 -0700 > Subject: [PATCH] Let pseudo->users loop on duplicate versin of list > > pseudo->users list will change during find dominator. > That cause a bug in the ptrlist because the outer loop iterator > is not award of the deletion of the entry. > > Let the outer loop using a duplicate version of entry > to avoid this problem for now. When I see this description, the first thing I think is: "you have a problem with an object, you duplicate the object, not you have two problem (at least)". In short, how you will keep coherency between the two? So yes, without any doubts, this fixes the iteration in the outer loop not taking correctly in account the deletion in the inner loop. But is the code working correctly now? I don't think so. In fact, since the outer loop is using a copy of the initial list, now *any* changes in the list will siply be ignored by the outer loop. - if an user is removed from the users list (for example in a position much further than the current position in the inner), previously, the inner loop will of course not have processed this user, while now it will process it although this user no more a user of this pseudo. It there any explanation which could explain that the current behaviour is correct? - same if the inner loop add a new user, now the outer loop will never process this user. To be clear, the issue I'm raising here is not about 'maybe missing an optimisation' but well a question of applying an optimization while the real condition are in fatc not met, and thus producings incorrect code. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
