Commit 2a4b245052 ("Makefile: clean up and simplify", 15-07-2017), moved
a PKG_CONFIG invocation from command scope to a top-level make variable
setting. For users who don't have libxml installed, this results in
pkg-config issuing warning messages on _each_ invocation of make:
$ make
...
Package libxml-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libxml-2.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libxml-2.0' found
...
$
In order to suppress the message, move the LIBXML_CFLAGS make variable
setting into the $(HAVE_LIBXML) conditional.
Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
---
Hi Christopher,
I like the 'selfcheck' (dog-fooding) target - many years ago I had
patches to make sparse run clean on itself (both Linux and Cygwin).
I didn't get around to getting all of them upstream. I just tried
a selfcheck on cygwin and Linux and neither were clean. ;-)
ATB,
Ramsay Jones
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index ae81586..4214e17 100644
--- a/Makefile
+++ b/Makefile
@@ -62,6 +62,7 @@ ifeq ($(HAVE_LIBXML),yes)
PROGRAMS+=c2xml
INST_PROGRAMS+=c2xml
c2xml_EXTRA_OBJS = `$(PKG_CONFIG) --libs libxml-2.0`
+LIBXML_CFLAGS := $(shell $(PKG_CONFIG) --cflags libxml-2.0)
else
$(warning Your system does not have libxml, disabling c2xml)
endif
@@ -194,7 +195,6 @@ ifneq ($(DEP_FILES),)
include $(DEP_FILES)
endif
-LIBXML_CFLAGS := $(shell $(PKG_CONFIG) --cflags libxml-2.0)
c2xml.o c2xml.sc: CFLAGS += $(LIBXML_CFLAGS)
%.o: %.c $(LIB_H)
--
2.13.0
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
