On Sun, Jul 09, 2017 at 09:07:06AM -0700, Christopher Li wrote: > On Sun, Jul 9, 2017 at 3:26 AM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > >> > >> - repeat_phase &= ~REPEAT_CFG_CLEANUP; > >> + repeat_phase |= REPEAT_CSE ; > > > > It would be good to add a comment for why the '|= REPEAT_CSE' is needed here. > > > > You are right. > > Actually I just find out that is not needed. I was having impression that I > need that to pass one of the test-suit. It seems fine without. It could have made a difference in the test suite because killing unreachable code can create new simplification opportunities. > It pass the > full kernel check as well. What do you mean exactly by 'pass full kernel check'? That you get exactly the same warnings with & without the patch? > From 484a3a27d95b4bf3be9ac4b9bcf1aca1abe3ac19 Mon Sep 17 00:00:00 2001 > From: Christopher Li <sparse@xxxxxxxxxxx> > Date: Sat, 8 Jul 2017 19:34:49 -0700 > Subject: [PATCH] move kill_unreachable_bbs to outer cse stage > > The current way of kill_unreach_bbs in insert_branch() > cause delete entry in ptrlist that the upper level > caller is looping on. I know what you're talking about but otherwise, I really can't parse this sentence. Anyway, I think that this bug merit a much better commit message. It would also be nice to know why the patch that came with the bug report have been discarded without a single comment. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
