Re: [PATCH] Adding ignored attribute optimize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 2, 2017 at 12:58 PM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
> "should report error" ...
> What error exactly? Is there something that doesn't work on sparse
> or on GCC's side regarding this 'require_context'? What need to be
> fixed exactly?

Have you look at the require_context code causing the warning in the
kernel? That code only issue require_context when compiling with sparse.

The fix should be just either convert to context parsing sparse supported,
implement in sparse, or just remove the require_context in kernel. It is
not doing any thing there right now. What else do you thing it is the
right fix for it?

>
> That's *exactly* why sparse should *not* report. You have no way to
> tell if what you're reporting is legitimate or not. And in most
> cases it's legitimate on GCC's side but you still want to report it.

I don't like sparse warn on the legit gcc attribute either.
I have some patch should make both of us happy.

GCC is open. It is not that hard to get a full list of gcc supported
attribute names.  I add the full list of gcc supported attribute list
into the sparse. Sparse should not warn on any known gcc attributes
any more. Patch on the way.

Let's be done with this.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux