On Thu, Jun 29, 2017 at 12:04 AM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: > There is also a long time 'require_context' in drivers/block/drbd,/ > a failed attempt to fix or extend sparse's handling of lock context. > Why is it still there after all those years, I have no idea. Yes, I notice that one too. But that one require to fix in the kernel side. Sparse does not support that kind of syntax. > > Anyway, my position about these unknown attributes is still the same > of course: we should simply ignore them instead of annoying people > with useless warnings. I have carefully consider your idea. It will have other unwanted behavior. That is why I did not apply your patch to change the default as no warning. Let say some one typo the sparse specific attribute "__contxt__" instead of "__context__". Sparse will not give warning about those typo. The statement become an no-op. It will be very hard for developer to find out what is going on. In this case, we do want to give out warning on unknown sparse specific attributes. Does it make sense? Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
