On Thu, Jun 15, 2017 at 4:18 PM, Dibyendu Majumdar <mobile@xxxxxxxxxxxxxxx> wrote: > > I notice also that in test_inspect there is the following: > > FOR_EACH_PTR_NOTAG(filelist, file) { > struct symbol_list *syms = sparse(file); > expand_symbols(syms); > concat_symbol_list(syms, &view_syms); > } END_FOR_EACH_PTR_NOTAG(file); > > Therefore if the symbols are dropped when the file scope ends, what is > supposed to happen above? It will not impact the above code. Because syms already taken out from the parsing. It is just the per file symbols can't be lookup any more. Here you only care about the compile result symbol (syms). That is fine. Some other application like ctags want to examine ALL available symbols. It will be hard from them to reach some of the symbol after you remove them from the lookup table. I think that is the only reason to delay the removal of the symbol to new_file_scope() rather than end_file_scope(). If you have already got the list of symbol you are interested in. No impact for you. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html