On Thu, May 11, 2017 at 10:57 PM, Christopher Li <sparse@xxxxxxxxxxx> wrote: >> + return nbr - i; > > Here if you want to return negative value it should be i - nbr. > Of course if you only care about return zero or not then it does > not matter. The call in this patch does only compare to zero > any way. You're right, I wanted a negative number and the comment says so. v3 is coming. Must be tired today. Thanks for noticing this. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html