Looks good.
Signed-of-by: <sparse@xxxxxxxxxxx>
On Thu, May 11, 2017 at 1:46 PM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
> +static int get_phisources(struct instruction *sources[], int nbr, struct instruction *insn)
> +{
> + pseudo_t phi;
> + int i = 0;
> +
> + assert(insn->opcode == OP_PHI);
> + FOR_EACH_PTR(insn->phi_list, phi) {
> + struct instruction *def;
> + if (phi == VOID)
> + continue;
> + if (i >= nbr)
> + return 1;
> + def = phi->def;
> + assert(def->opcode == OP_PHISOURCE);
> + sources[i++] = def;
> + } END_FOR_EACH_PTR(phi);
> + return nbr - i;
Here if you want to return negative value it should be i - nbr.
Of course if you only care about return zero or not then it does
not matter. The call in this patch does only compare to zero
any way.
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
