On Tue, Apr 14, 2015 at 2:25 AM, Martin Liška <mliska@xxxxxxx> wrote:
> Remove comments related to GCC 4.x branch and workaround for
> asm_volatile_goto which is fixed in GCC 5 release.
How sure are you that it is *really* fixed? Because it wasn't, last we saw.
It was originally claimed to be fixed in 4.8.2, but that turned out to
be wrong. See commit 5631b8fba640 ("compiler/gcc4+: Remove inaccurate
comment about 'asm goto' miscompiles"), and
https://lkml.org/lkml/2014/2/12/817
which shows that the bugzilla you reference is at the very least
unreliable. Apparently the gcc test-case didn't catch all the
problems.
IOW, just leave the workaround. It has no actual cost, and the gcc bug
wasn't obviously fully fixed. There are apparently very few users of
"asm goto" (probably partly because of the limitations of it,
particularly the "no outputs").
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
