On Fri, Feb 6, 2015 at 1:52 PM, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote: >> Can you submit a patch for adding the test case you found? >> I will include those into the the test suit. > > I'd like to, but I'm not sure how to write the test in terms of sparse's > test frame work. How do I check that the string is as expected? You can use ./test-parsing to evaluate the test file. $ cat /tmp/v.c #define BACKSLASH "\\" static const char a[] = BACKSLASH "a"; static const char b[] = BACKSLASH "b"; # on current master branch it shows: $ ./test-parsing /tmp/v.c .align 1 char static const [toplevel] a[0] = movi.64 v2,&"\7b" ld.24 v3,[v2] , .align 1 char static const [toplevel] b[0] = movi.64 v5,&"\7b" ld.24 v6,[v5] # on the review-immutable-string branch it shows: $ ./test-parsing /tmp/v.c .align 1 char static const [toplevel] a[0] = movi.64 v2,&"\\a" ld.24 v3,[v2] , .align 1 char static const [toplevel] b[0] = movi.64 v5,&"\\b" ld.24 v6,[v5] Notice that "\\a" and "\\b" was not there before the bug was fixed. The test suit is just some C file in the "validations" directory. Each file has a test name and optional how to invoke the C file and what to expect from the running result. You should able to find some example in the test suit. Or, you can just submit a patch to include those C file in the "validations" directory. Let some one help you complete the test suit. You run the test suit as: make check Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html