On Sun, Feb 01, 2015 at 09:30:44PM -0800, Christopher Li wrote: > On Sat, Jan 31, 2015 at 6:19 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > The purpose of show_data() is to visualize data, more or less > > I think show_data() is a bad name. Data is very generic term, > it has not specific meaning what exactly is that data. > > What you really want to show is the initializer expression. > Make the function name reflect that. Yes, the name is too generic. The purpose was to use 'data' in opposition to 'code'. > > diff --git a/linearize.c b/linearize.c > > Why is this function belongs to linearize.c? > It has nothing to do with linearization instruction. It has > every thing to do with the AST structure. > > I suggest that move this code to show-parse.c. > There are many functions showing internal of the AST > there. Well, I put it in linearize because it's where show_entry() is defined and since I wanted this new show function be its complement, it seemed to me much better to put it there than in show-parse.c Even more so because I'm not interested in showing anything close to the AST, on the contrary, I want to show the values like you would find them in an assembler code file generated by a compiler after constant folding, string expansion, type coercion, ... Anyway, my intention was not to have it included as is (mainly because it's not complete) but only as a quick tool to investigate the bug that Rasmus have reported. I'll try to complete it and resubmit it then, taking your remarks in account. Regards, Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
