On Sun, Oct 19, 2014 at 10:21 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> wrote: > Sorry for the late reply, it's been a busy few days. ;-) > > On 16/10/14 02:45, Christopher Li wrote: >> Hi, >> >> I create a branch in the chrisl repo call "review-ramsay" for your new >> follow up patches. >> I plan to do incremental fix up if any on that branch. Then when we >> both happy about it, >> I will do rebase and smash the commit before push to master branch. > > Yes, I noticed the new branch - thanks! > > Did you have any thoughts regarding Josh Triplett's comments on the > "compile-i386.c: don't ignore return value of write(2)" patch? I am fine with either way. The current fix is fine. If you are up for a new xwrite function, that is of course fine as well. Using printf() is not much an improvement because printf() can still return bytes less than the amount you requested. > > No, no, you don't want to do that even on Linux (let alone more > exotic platforms like Windows, MinGW and cygwin). In that case, I will leave the patch as it is. Thanks for the explain. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
