Some versions of gcc (e.g. v4.8.2) complain about ignoring the return
value of a call to the write(2) system call, since the system header
files have marked its declaration with the warn_unused_result attribute.
In order to suppress the compiler warning, check the return value from
'write' and, if it indicates an error (a negative return value), exit
the process using 'die' to display an error message. Replace a second
call to 'write', which does not provoke a compiler warning, with similar
code for consistency.
Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>
---
Hi Chris,
This is an (almost) minimal patch to suppress the compiler warning.
You could drop the second hunk (and edit the commit message) if you
prefer an absolutely minimal patch. :-D
ATB,
Ramsay Jones
compile-i386.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/compile-i386.c b/compile-i386.c
index 88169ec..44b72ec 100644
--- a/compile-i386.c
+++ b/compile-i386.c
@@ -732,7 +732,8 @@ static void emit_insn_atom(struct function *f, struct atom *atom)
atom->insn,
comment[0] ? "\t\t" : "", comment);
- write(STDOUT_FILENO, s, strlen(s));
+ if (write(STDOUT_FILENO, s, strlen(s)) < 0)
+ die("can't write to stdout");
}
static void emit_atom_list(struct function *f)
@@ -742,9 +743,8 @@ static void emit_atom_list(struct function *f)
FOR_EACH_PTR(f->atom_list, atom) {
switch (atom->type) {
case ATOM_TEXT: {
- ssize_t rc = write(STDOUT_FILENO, atom->text,
- atom->text_len);
- (void) rc; /* FIXME */
+ if (write(STDOUT_FILENO, atom->text, atom->text_len) < 0)
+ die("can't write to stdout");
break;
}
case ATOM_INSN:
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
