On Wed, Oct 08, 2014 at 06:26:23PM +0800, Christopher Li wrote: > On Tue, Oct 7, 2014 at 5:45 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > >> + system ($check) == 0 or die; > > > > This just enables -Werror for everyone so now I can't run Sparse on > > itself now because there are old errors from 2007. > > > > lib.c:192:6: error: symbol 'error_die' redeclared with different type (originally declared at lib.h:97) - different modifiers > > lib.c:201:6: error: symbol 'die' redeclared with different type (originally declared at lib.h:93) - different modifiers > > It depend on how you invoke sparse. > Do you invoke sparse by some thing like "make CC=./cgcc"? Yes. In my makefile I have: ifeq ($(CC),"") CC = gcc endif > > > > > Btw, these errors also disable warnings for the rest of the file... I > > don't think just because there are different modifiers it means that > > we should give up looking for other warnings. In the kernel we miss > > some endian bugs because of this. > > Are you suggesting change that type different error into warnings so > sparse can still check the rest of the file? Let me look at this more closely again and write some patches. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html