On 07/10/14 04:55, Christopher Li wrote: > On Mon, Oct 6, 2014 at 6:31 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> wrote: >> On 06/10/14 00:33, Christopher Li wrote: >>> My gcc(4.8, FC20) does not support "-print-multiarch". >> >> Yep, same is true for cygwin. > > I see, I thought your patch is expecting some thing from gcc. > Then how to you test this code path? Well, I slightly mis-spoke. Of the two cygwin installations I have, one has a version of gcc which supports '-print-multiarch' and one doesn't (i.e. it isn't really the version of cygwin, but gcc that seems to matter). In any case, cygwin is not a "multiarch" system, so on my 64-bit cygwin installation 'gcc -print-multiarch' prints a blank line (ie an empty string) and exits with 0 status. On my old 32-bit cygwin installation (if memory serves me correctly) then gcc prints an error message and exits with non-zero status. This patch is old enough that it was originally tested on my old cygwin installation (this patch was developed on my old laptop), so I haven't tested there for some time. However, before sending this series I distinctly remember simulating this on 64-bit cygwin by editing the Makefile and changing the '-print-multiarch' option to '-print-junk', which _should_ have the same effect. [ie the $(MULTIARCH_TRIPLET) make variable should be set to the empty string on your FC20 system.] > >>> >>>> + if (multiarch_dir && *multiarch_dir) { >>>> + add_pre_buffer("#add_system \"/usr/include/%s\"\n", multiarch_dir); >>>> + add_pre_buffer("#add_system \"/usr/local/include/%s\"\n", multiarch_dir); >>>> + } >>> >> Again, it works for me. :-D > > So I guess multiarch_dir can be empty here. I just did not expect > that. Yes, indeed this _must_ be empty on non-multiarch systems. [This was developed on Ubuntu, which is a multiarch system (and I'm now on Linux Mint 17, which is also). Until now, I didn't know that Fedora was not! :-D ] > > Is it always prefix with "/usr/include/" and "/usr/local/include" for > different distributions? I can't quite remember how I came up with this list (it was a while ago), but I think I had a look at the gcc source code. (Hmm, don't quote me on that! ;-) ). ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html