Re: [PATCH 04/10] compile-i386.c: don't mix calls to write(2) with stdio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/09/14 03:34, Christopher Li wrote:
> On Sat, Sep 27, 2014 at 9:00 PM, Ramsay Jones
> <ramsay@xxxxxxxxxxxxxxxxxxx> wrote:
>>>> -       write(STDOUT_FILENO, s, strlen(s));
>>>> +       printf("%s", s);
>>>
>>
>> I was only really fixing the compiler warning (in an side-ways fashion).
>> (although I think it is an improvement).
> 
> I would just check the return value and "die" if there is an error to silence
> the error.

Hmmm, I can change the patch to do that if you prefer.

Having said that, given that this is not currently maintained, what
do you think about a patch to remove it?

[Are you hoping someone will pick it up again soon?]

Let me know which patch you would like to see.

ATB,
Ramsay Jones



--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux