On Sep 22, 2014, at 12:01 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > On Mon, Sep 22, 2014 at 10:55:11AM -0700, Mark D Rustad wrote: >> Avoid W=2 nested-externs warning by moving the nested extern to >> a normal extern. This eliminates that warning which is generated >> for every inclusion of sched.h in a kernel build when W=2 is used. >> This also removes a point of maintenance if the definition of >> delayacct_on were ever to change. > > Yeah, so why is that warning worth using? Just disable the warn if > you're bothered by it. I assume that nested-externs is included in W=2 because many uses of them, especially with function prototypes, creates a risk of inconsistent declarations. The kernel has a fair number of them that seem to have been added to disentangle include files. If they are judged to be worthwhile, then it would be good to silence the warnings so that attention can be given to other instances of the warnings. If those nested externs are not worth the risk, well that is a different conversation. -- Mark Rustad, Networking Division, Intel Corporation
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
