On Sun, Aug 28, 2011 at 03:14:18PM +1200, Chris Forbes wrote: > + case EXPR_BINOP: > + case EXPR_COMMA: > + case EXPR_COMPARE: > + case EXPR_LOGICAL: > + case EXPR_ASSIGNMENT: > + return expr_equiv(lhs->left, rhs->left) && > + expr_equiv(lhs->right, rhs->right); [...] > + if ((a == b) && (a == b)) /* should warn */ > + bar(); > + > + if ((a == b) && (b == c)) /* should not warn */ > + bar(); Should it maybe also handle cases like this? if ((a == b) && (b == a)) bar(); Thanks, Jonathan Neuschäfer -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html