On Mit, 2010-10-20 at 08:29 +0100, Al Viro wrote: > On Wed, Oct 13, 2010 at 04:45:10PM +0200, Bernd Petrovitsch wrote: > > > rename the local variables "true" and "false" to "if_true" and "if_false", > > respectively to not clash with the well-known "keywords" defined by C99. > > This is similar to commit 0be55c9. > > These are not keywords... Said that, things like ACK, that's why "keywords" is quoted above. > if (!cond->value) > true = false; > if (!true) > true = cond; > certainly reek of IOCCC. I'd rather avoid "if_true" as replacement, though. > If anything, true_expr and false_expr would make more sense. I have no strong feelings about the replacement and just followed the change in the referenced commit. Chris, should I respin the patch with *_expr? Bernd -- mobile: +43 664 4416156 http://www.sysprog.at/ Linux Software Development, Consulting and Services -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
