On Tue, Oct 19, 2010 at 04:07:42PM -0700, Christopher Li wrote: > On Tue, Oct 19, 2010 at 2:31 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Oct 19, 2010 at 10:03:42PM +0200, Tomas Klacko wrote: > >> @@ -188,7 +188,7 @@ static struct symbol_op char_op = { > >> ? ? ? .type = KW_SPECIFIER, > >> ? ? ? .test = Set_T|Set_Long|Set_Short, > >> ? ? ? .set = Set_T|Set_Char, > >> - ? ? .class = CChar, > >> + ? ? .klass = CChar, > >> ?}; > > > > Egads... ?Why not "kC1455", while you are at it? ?Seriously, if you feel the > > need to rename that, at least use something more palatable. ?Hell, even > > adjust_type would be better... > > I suggested the "klass", my bad. How about your suggest a perfect name > and we will use it. Is "adjust_type" good enough? type_group, probably... FWIW, I'd probably spell that enum in parse.c as CInt = 0, CSInt = 1, CUInt = 2, CReal = 3, CChar = 4, CSChar = CChar + CSInt, CUChar = CChar + CUInt while we are at it. -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html