On Fri, 2007-07-27 at 11:27 -0700, Andrew Morton wrote: > On Fri, 27 Jul 2007 10:05:16 -0700 > Josh Triplett <josht@xxxxxxxxxxxxxxxxxx> wrote: > > > > Sparse warnings... I think it shouldn't complain either, unless > > > called with extra parameter. > > > > Good point; Sparse shouldn't warn about this by default. I've turned > > that off in latest Sparse from Git, so you need to give -Wdo-while or > > -Wall to get warnings about that. However, the kernel gives -Wall, so > > you'll still see the warnings there. > > I believe reeducating sparse was the best fix here. I think I'll now > have a quiet accident with codingstyle-proscribe-do-while-without-braces.patch I didn't just submit the patch because Sparse warns about it. I submitted the patch because of the coding style preference that led to the Sparse warning. Also, if this really *shouldn't* form part of the kernel style, then the kernel should use -Wno-do-while with -Wall, or should stop using -Wall. That said, I don't care all that much about the patch, so I won't push further for it one way or another. - Josh Triplett - To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
