On Sat, 24 Mar 2007 07:44:56 +0100 Sam Ravnborg wrote: > > > > > You could argue that the error from sparse could be better but > > > it is preferable to have consistent style over the kernel. > > > > I lean more towards "is it valid C or not"? > I thought all the attribute() stuff was purely gcc extensions. That's probably correct. I should have said something more like "is it accepted by a widely-used C compiler or not". :) But I would not complain if sparse just read & ignored the attributes (rather than throwing errors on them). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html