Re: [PATCH 1/3] qcom: soc: llcc-slice: Clear the global drv_data pointer on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 10, 2018 at 11:24:26AM -0800, Doug Anderson wrote:
> Hi,
> 
> On Thu, Oct 25, 2018 at 9:38 AM Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> wrote:
> > @@ -142,6 +148,9 @@ int llcc_slice_activate(struct llcc_slice_desc *desc)
> >         int ret;
> >         u32 act_ctrl_val;
> >
> > +       if (IS_ERR(drv_data))
> > +               return PTR_ERR(drv_data);
> > +
> 
> There's a conflict with your other patch in commit ff49a5198fc1
> ("FROMLIST: soc: qcom: llcc-slice: Add error checks for API
> functions") right here.  Maybe you should send a v2?  Presumably patch
> #3 in this series would be dropped since there was some controversy
> over it?

Yeah, patch 3 can be dropped. I'll try a v2 against the latest + greatest from
Andy.

Jordan
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux