I was testing LLCC with the GPU driver and I happened to have a malformed DT entry and hilarity ensued since the devm allocated global pointer was destroyed by the failed probe function long before I attempted to call llcc_slide_getd(). And then I felt bad for adding too many lines so I consolidated the regmap code from the probe function. Finally, I noticed that there was a inconsistency between the static inline stub and the actual llcc_slide_getd() function. Jordan Crouse (3): qcom: soc: llcc-slice: Clear the global drv_data pointer on error qcom: soc: llcc-slice: Consolidate some code qcom: soc: llcc-slice: Return correct error for llcc_slice_getd stub drivers/soc/qcom/llcc-sdm845.c | 6 ++ drivers/soc/qcom/llcc-slice.c | 101 +++++++++++++++++++---------- include/linux/soc/qcom/llcc-qcom.h | 8 ++- 3 files changed, 81 insertions(+), 34 deletions(-) -- 2.18.0