Hi, On Fri, Dec 7, 2018 at 10:15 AM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > > Vivek, > > On 04/12/18 6:07 PM, Vivek Gautam wrote: > > Hi Kishon, > > > > On Tue, Dec 4, 2018 at 1:44 PM Kishon Vijay Abraham I <kishon@xxxxxx> wrote: > >> > >> Hi Andy Gross, David Brown, Vivek, > >> > >> On 30/11/18 3:43 AM, Evan Green wrote: > >>> This series fixes the QMP PHY bindings, which had specified #clock-cells > >>> in the parent node, and had set it to 1. Putting it in the parent node is > >>> wrong because the clock providers are the child nodes, so this change > >>> moves it there. Having it set to 1 is also wrong, since nothing is ever > >>> specified as to what should go in that cell. So this changes it to zero. > >>> Finally, this change completes a little bit of code to actually allow these > >>> exposed clocks to be pointed at in DT. > >>> > >>> I had no idea how to fix up ipq8074.dtsi. It seems to be completely wrong in > >>> that it doesn't specify #clock-cells at all, has no child nodes, and > >>> specifies clock-output-names in the parent node. As far as I can tell this > >>> doesn't work at all. But I can't add the child nodes myself because I don't know > >>> 1) how many there are, and 2) the registers in them. I also have no way to test it. > >>> > >>> Speaking of testing, I was able to test this on sdm845, but haven't tested msm8996. > >> > >> Can someone help test this series in msm8996? > > > > Sure, will give it a try tomorrow. > > I'm planning to close the merge by today. Can you test this series please? Sorry, got held up with an issue yesterday. Will update you in couple of hours. Thanks Vivek [snip] -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
