Re: [PATCH v5 1/2] arm64: dts: msm8996: add prng-ee node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 10, 2018 at 06:08:22PM +0530, Vinod wrote:
> On 10-09-18, 15:34, Stanimir Varbanov wrote:
> 
> > >>> +			compatible = "qcom,prng-ee";
> > >>> +			reg = <0x83000 0x1000>;
> > >>
> > >> reg = <0x00083000 0x1000>;
> > > 
> > > that doesn't help IMO and makes it bit harder to read, looking at the
> > > dtsi, I do not see many examples of leading zeros (only couple with
> > > single one)
> > 
> > I think this might be an undocumented rule.
> 
> Then it is not being followed :D.
> 
> Andy, what do you prefer? 0x83000 or 0x00083000

I'd prefer 0x00083000.  The only time a shortened form is ok for me is if it's
0x0.

Regards,

Andy



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux