Re: [PATCH v5 1/2] arm64: dts: msm8996: add prng-ee node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10-09-18, 15:13, Stanimir Varbanov wrote:
> 
> 
> On 09/10/2018 01:06 PM, Vinod Koul wrote:
> > RNG hardware in 8996 features (Execution Environment) EE for
> > HLOS to use, add the node for prng-ee for msm8996.
> > 
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8996.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index cd3865e7a270..285e6630320a 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -729,6 +729,13 @@
> >  			};
> >  		};
> >  
> > +		qcom_rng: qrng@83000 {
> 
> I think this should be just:
> 
> rng@83000 {

yes agreed, we should not have this in node name, will update for both

> 
> > +			compatible = "qcom,prng-ee";
> > +			reg = <0x83000 0x1000>;
> 
> reg = <0x00083000 0x1000>;

that doesn't help IMO and makes it bit harder to read, looking at the
dtsi, I do not see many examples of leading zeros (only couple with
single one)

-- 
~Vinod



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux